Upgraded Snappier to 1.2.0 to let license compliance checks find its license #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for team: This change mostly looks good, but it drops support for some targets that we still support. Specifically, the driver targets .NET 4.7.2, .NET Standard 2.1, and .NET 6. From those. The updated version of this Snappier supports .NET Standard 2.0, .NET 6, and .NET 8. This means that anything that targets .NET Standard 2.1, but does not target .NET Standard 2.0 or .NET 6 will not work. There are no in-support platforms from Microsoft that fit this combination, but that doesn't stop people who are currently using out-of-support platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the driver depends on Snappier 1.0.0 which is probably badly annotated and doesn't provide a license identifier (though it provides a link to the license text)
This upgrade is to support automated license checks, which are required to ensure legal compliance.